Overlay Ads editing

Report Nuevoplayer bugs here. Please make sure they haven't been reported or fixed already.

Overlay Ads editing

Postby Loktar » Sat Jan 30, 2010 3:03 pm

Hi.

I think i've found a Bug. In editing Overlay ads when editing.

If you change the settings of one Overlay Ad it gives an error Message Like:" Not edited" or something. Additionaly the edited Ad is the same as the other Overlay. Means: The edited Ad has exactly the same specification of another existing Ad.

Steps to reproduce:

Create TWO different Overlay Ads.
Edit ONE of the Ads.
You will see the Error Message and after that you will have two Overlay Ads with the same Specifications.

EDIT: Found the Bug. In overlayedit.php the sql query is missing a WHERE :)
Loktar
 
Posts: 11
Joined: Wed Jan 13, 2010 6:30 pm

Re: Overlay Ads editing

Postby dargre » Sun Jan 31, 2010 5:47 am

I don't understand your happiness....
You know what to correct then correct: WHERE ID ='".$ID."'";

Anyway this issue was removed time ago, don't even remember when...
Thank you,
Nuevolab Team
dargre
 
Posts: 71
Joined: Mon Sep 07, 2009 3:47 am

Re: Overlay Ads editing

Postby Loktar » Sun Jan 31, 2010 3:11 pm

Hey Dargre,

I fixed that for me. Just wanted to let you know that my version had that bug. Maybe I've gotten an old version, because you said that it was fixed?
Loktar
 
Posts: 11
Joined: Wed Jan 13, 2010 6:30 pm

Re: Overlay Ads editing

Postby dargre » Mon Feb 01, 2010 1:57 am

Yep, always each early version comes with small bugs, mostly typos.
It's just a matter of time to find it out and usually those are really stupid small things.
But it's not to avoid when there are thousands line of code to write
Only Nuevoplayer flash action script is over 7000 lines of code.
Thank you,
Nuevolab Team
dargre
 
Posts: 71
Joined: Mon Sep 07, 2009 3:47 am

Re: Overlay Ads editing

Postby Loktar » Mon Feb 01, 2010 2:22 am

Yeah ok.

I don't wanted to attack you because of that, i just wanted to let you know. As i'am no total newbie to php i fixed that by myself. That was an easy one :) Thanks again for your excelent Support via email ( Lighttpd port issue... ). Please excuse my spelling, because english is not my native Tongue.
Loktar
 
Posts: 11
Joined: Wed Jan 13, 2010 6:30 pm

Re: Overlay Ads editing

Postby dargre » Mon Feb 01, 2010 6:27 am

Oh no, I'm happy with every bug report, especially if reported in friendly way.
But not all understand that each software must have bugs, even if developer do all his best.
Then such people got furious instead of just friendly talk to make things working.

Anyway, thanks for report.
There can be more users with this bug, so hope they know now how to correct it.
It's file "siteadmin/modules/nuevo/overlay_edit.php"
SQL query line ends with: active ='".mysql_real_escape_string($data['active'])."'";
and should be: active ='".mysql_real_escape_string($data['active'])."' WHERE ID ='".$ID."'";

BTW.
Your English is enough to understand things.
Thank you,
Nuevolab Team
dargre
 
Posts: 71
Joined: Mon Sep 07, 2009 3:47 am


Return to Bug Tracking

Who is online

Users browsing this forum: No registered users and 0 guests